[PULL] build fix, GC clipping cleanup

Jamey Sharp jamey at minilop.net
Mon Oct 17 14:49:19 PDT 2011

On Mon, Oct 17, 2011 at 02:06:55PM -0700, Keith Packard wrote:
> On Wed, 5 Oct 2011 08:30:56 -0700, Jamey Sharp <jamey at minilop.net> wrote:
> > Alright, the pixmap hooks have weird undocumented constraints, and
> > maybe we'll figure out something clever someday. Meanwhile, would you
> > please merge the other three commits?
> For other ABI changes like this, we've provided compile-time tests you
> can use to switch the code without using the X server ABI version
> information. That way, it's easy to make video drivers compile across
> the change.
> The hardest part will be picking a suitable name which makes the
> difference reasonably clear.
> Otherwise, these changes look good to me; fixing the driver to handle
> the change was straightforward.

Augh, another round on the patches I'm stalled waiting for. It's a fair
critique though.

Do you care if drivers still work in between the two patches? I'm not
keen on adding two separate #defines when the changes are conceptually
paired like this, but the second patch is only clearly correct after the
first is in place, so I hate to squash them. At least they should both
trigger compile-time errors in any code that isn't updated, making the
cause of a bisect failure somewhat obvious.

Could you at least merge the stupid trivial gitignore fix so I can get
something out of my tree?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111017/b46c0b9c/attachment.pgp>

More information about the xorg-devel mailing list