[PATCH 10/12] composite/xinerama: free newPix on error path.

Dave Airlie airlied at gmail.com
Thu Oct 20 03:44:26 PDT 2011


From: Dave Airlie <airlied at redhat.com>

newPix could be leaked if AddResource failed.

pointed out by coverity scan.

Signed-off-by: Dave Airlie <airlied at redhat.com>
---
 composite/compext.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/composite/compext.c b/composite/compext.c
index 722587a..01bd578 100644
--- a/composite/compext.c
+++ b/composite/compext.c
@@ -725,8 +725,10 @@ PanoramiXCompositeNameWindowPixmap (ClientPtr client)
 	}
 
 	if (!AddResource (newPix->info[i].id, RT_PIXMAP,
-			  (pointer) pPixmap))
+			  (pointer) pPixmap)) {
+	    free (newPix);
 	    return BadAlloc;
+	}
 
 	++pPixmap->refcnt;
     }
-- 
1.7.6.4



More information about the xorg-devel mailing list