[PATCH 04/12] xf86: don't call getscreenpixmap in enabledisablefbaccess

Jamey Sharp jamey at minilop.net
Fri Oct 21 07:38:07 PDT 2011


Would be nice to note in the commit message that the references to pspix
were removed in commit 5c6a2f93ebc16a78093782b442306de23ae94e78.

Reviewed-by: Jamey Sharp <jamey at minilop.net>

On Thu, Oct 20, 2011 at 11:44:20AM +0100, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> This isn't used anywhere in here.
> 
> Pointed out by coverity scan.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  hw/xfree86/common/xf86Helper.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c
> index cf57752..96444d1 100644
> --- a/hw/xfree86/common/xf86Helper.c
> +++ b/hw/xfree86/common/xf86Helper.c
> @@ -1006,9 +1006,7 @@ xf86EnableDisableFBAccess(int scrnIndex, Bool enable)
>  {
>      ScrnInfoPtr pScrnInfo = xf86Screens[scrnIndex];
>      ScreenPtr pScreen = pScrnInfo->pScreen;
> -    PixmapPtr pspix;
>  
> -    pspix = (*pScreen->GetScreenPixmap) (pScreen);
>      if (enable)
>      {
>  	/*
> -- 
> 1.7.6.4
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111021/ba174c16/attachment.pgp>


More information about the xorg-devel mailing list