[PATCH] unify capitalization of joystick properties

Devin J. Pohly djpohly+xorg at gmail.com
Mon Sep 5 06:46:17 PDT 2011


On 09/05/2011 01:29 AM, Peter Hutterer wrote:
> On Sat, Sep 03, 2011 at 07:00:07PM -0400, Devin J. Pohly wrote:
>> From: "Devin J. Pohly"<djpohly+xorg at gmail.com>
>>
>> the axis keys high/low properties were inconsistently capitalized,
>> leading to potential confusion as to why one works but not the other.
>>
>> Signed-off-by: Devin J. Pohly<djpohly+xorg at gmail.com>
>> ---
>
> urgh. although a clear typo, I'd rather not change this now. We've had 3
> releases already with that issue, changing it now has the potential to break
> things for anyone who's already adjusted the code for this.
>
> Cheers,
>    Peter

Ah, I see.  "Referer" strikes again. :)

We still might get away with it... if anyone's used it, Google doesn't 
know.  Searching things like +"axis keys (high)", xichangeproperty 
+"axis keys", and the like only returns results from 
cgit.freedesktop.org.  I haven't found any documentation outside the 
source code, so it's possible that virtually nobody has used the string 
representation of this property yet.

*dp

(sorry for double-send - forgot to "plus" my email address to get the 
list to take it)

>>   include/joystick-properties.h |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/joystick-properties.h b/include/joystick-properties.h
>> index 49ef800..36f4082 100644
>> --- a/include/joystick-properties.h
>> +++ b/include/joystick-properties.h
>> @@ -99,7 +99,7 @@ typedef enum _JSTK_MAPPING {
>>
>>   /** Scancodes for axis in high position */
>>   /* 8 bit, 4 per axis */
>> -#define JSTK_PROP_AXIS_KEYS_HIGH "Axis keys (high)"
>> +#define JSTK_PROP_AXIS_KEYS_HIGH "Axis Keys (high)"
>>
>>   /** Set the mapping of each button to
>>       none, x, y, zx, zy, button, key, speed_multiply,
>> --
>> 1.7.6.1


More information about the xorg-devel mailing list