[PATCH libXt] Install ErrorDB into a $datarootdir-path, not $libdir.

[Gaetan Nadon]

On Wed, 2011-09-07 at 15:00 +0000, Egbert Eich wrote:

> Sorry, forgot to metion in the header: this was for libXt.
> 

Can you also explain in the commit text the reasons why the location has
changed? Most likely it is because the data it contains is architecture
independent. Any impact regarding backward compatibility? Any thing a
user should do after an upgrade?

I don't know anything about libXt, just noticed the commit text being
identical to the code.

Why is datarootdir being added to the pc file? I don't see it being used
in any way through pkg-config. Usually there is a separate variable for
specific resources being queried by other modules. For example the
server has sdkdir for the development header files. Should they ever
change location, the callers using pkg-config would not be affected.

This is the list of variables used by modules to query resources from
other modules:

        --variable=appdefaultdir 
        --variable=dridriverdir 
        --variable=icondir 
        --variable=includedir 
        --variable=includex11dir 
        --variable=pythondir 
        --variable=sdkdir 
        --variable=sysconfigdir 
        --variable=systemdsystemunitdir 
        --variable=xcbincludedir 
        --variable=xkb_base 
        --variable=xthreadlib 

If there is a need for a module to get at the XtErrorDB path, I would
suggest an explicit variable name. One should be able to figure it out
simply by looking at the pc file.

> 
> Cheers,
> 	Egbert.
> 
> On Wed, Sep 07, 2011 at 04:51:02PM +0200, Egbert Eich wrote:
> > Signed-off-by: Egbert Eich <eich at freedesktop.org>
> > ---
> >  src/Makefile.am |    2 +-
> >  xt.pc.in        |    1 +
> >  2 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/src/Makefile.am b/src/Makefile.am
> > index 2b39ec5..727c077 100644
> > --- a/src/Makefile.am
> > +++ b/src/Makefile.am
> > @@ -4,7 +4,7 @@ BUILT_SOURCES = $(BUILT_FILES)
> >  CLEANFILES = $(BUILT_SOURCES)
> >  
> >  SRCH_DEFINES = -DXFILESEARCHPATHDEFAULT=\"$(XFILESEARCHPATHDEFAULT)\"
> > -ERRORDB_DEFINES = -DERRORDB=\"$(libdir)/X11/XtErrorDB\"
> > +ERRORDB_DEFINES = -DERRORDB=\"$(datarootdir)/X11/XtErrorDB\"
> >  
> >  AM_CFLAGS = $(CWARNFLAGS) $(XT_CFLAGS) $(SRCH_DEFINES) $(ERRORDB_DEFINES) \
> >  	$(XTMALLOC_ZERO_CFLAGS)
> > diff --git a/xt.pc.in b/xt.pc.in
> > index 28ce24a..755e070 100644
> > --- a/xt.pc.in
> > +++ b/xt.pc.in
> > @@ -1,5 +1,6 @@
> >  prefix=@prefix@
> >  exec_prefix=@exec_prefix@
> > +datarootdir=@datarootdir@
> >  libdir=@libdir@
> >  includedir=@includedir@
> >  appdefaultdir=@appdefaultdir@
> > -- 
> > 1.7.3.4
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110907/bbcd570d/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110907/bbcd570d/attachment.pgp>