[PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

Jeremy Huddleston jeremyhu at apple.com
Thu Sep 15 01:20:02 PDT 2011


On Sep 15, 2011, at 2:58 AM, Julien Cristau wrote:

> On Wed, Sep 14, 2011 at 20:17:41 -0500, Jeremy Huddleston wrote:
> 
>> Every module building against xorg-server does not *Require* pixman nor
>> libpciaccess.  If such modules need pixman or pciaccess, they should be
>> depending on them directly rather than inheriting a dependency from
>> xorg-server.
>> 
> The thing is, most video drivers *do* need pixman and pciaccess, and
> inherit that dependency from the server (not to mention the fact that
> the server tends to hide the use of pixman_* by its own macros so it's
> not obvious where the dependency belongs).  Can we fix that first?

Wouldn't it be nice if the servers that we cared about were in the xorg-server tree itself, so I could try building with these changes on a linux machine to see what broke.  Oh wait, if we had the drivers in the tree to begin with we wouldn't need to do that anyways...

In all seriousness, yes.  This change is in xserver in this run on my tinderbox:
http://tinderbox.x.org/builds/2011-09-15-0003

I just kicked it off now, so hopefully it'll give us some idea of the impact in the morning and I can address that before this is pulled into the server.  Does this satisfy you enough for an Ack?



More information about the xorg-devel mailing list