[PATCH-V2] xserver: Optional backtrace handler
Barry Scott
barry.scott at onelan.co.uk
Fri Sep 23 05:23:22 PDT 2011
On Friday 23 September 2011 10:40:35 Simon Farnsworth wrote:
<snip>
> > diff --git a/include/os.h b/include/os.h
> > index a553f57..48debe9 100644
> > --- a/include/os.h
> > +++ b/include/os.h
> > @@ -542,5 +542,8 @@ extern _X_EXPORT void Error(const char *str);
> > extern _X_EXPORT void LogPrintMarkers(void);
> >
> > extern _X_EXPORT void xorg_backtrace(void);
> > +extern _X_EXPORT void xorg_init_backtrace(void);
> > +extern _X_EXPORT void xorg_cleanup_backtrace(void);
> > +extern const char *BacktraceHandlerPath;
> >
>
> I still think these ought to be _X_HIDDEN or _X_INTERNAL, rather than
> _X_EXPORT - they shouldn't be called by modules, for example.
>
Can one of the Xorg knowledge developers comment on this please?
What attribute should be used?
I'll create a V3 patch next week with Simon's feedback and for
this point once I get guidance.
Barry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110923/0e4ac4da/attachment.html>
More information about the xorg-devel
mailing list