[PATCH:xscope 06/14] Ensure ScopeHost global is initialized when built with USE_XTRANS

[Jeremy Huddleston]

Fair enough.  I remember at some point the xtrans path wasn't working for us on darwin, so we needed to use that other path for a while.  We're now using xtrans, but for some reason we're building --disable-unix-transport.  I don't quite remember why that wasn't working, so I'll try to resurrect that bug.

In any event, for your whole set:
Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>



On Sep 25, 2011, at 10:07, Alan Coopersmith wrote:

> On 09/25/11 12:07 AM, Jeremy Huddleston wrote:
>> 
>> On Sep 24, 2011, at 21:22, Alan Coopersmith wrote:
>> 
>>> It's gethostname, no "by", to get the name of the current host.
>> 
>> You're using gethostbyname here:
>> 
>>>> +    struct hostent *hp = gethostbyname(MyHostName);
> 
> Ah, that's down in the #else below the #ifdef USE_XTRANS code.
> The non-xtrans code is IPv4 only.
> 
> The default is xtrans if it's installed, and that's what I build
> with, and my binaries have the right calls in:
> 
> % nm -p xscope | grep get
> 00000000000004286328 U fgets
> 00000000000004286168 U getaddrinfo
> 00000000000004285912 U getenv
> 00000000000004285704 U geteuid
> 00000000000004285304 U gethostname
> 00000000000004285976 U getpeername
> 00000000000004285592 U getpid
> 00000000000004286024 U getservbyname
> 00000000000004286120 U getsockname
> 00000000000004286424 U gettimeofday
> 
> -- 
> 	-Alan Coopersmith-        alan.coopersmith at oracle.com
> 	 Oracle Solaris Platform Engineering: X Window System
>