[PATCH] dix: add valuator_mask_fetch_double()

Chase Douglas chase.douglas at canonical.com
Fri Sep 30 09:18:20 PDT 2011


On 09/29/2011 09:29 PM, Peter Hutterer wrote:
> Using this call simplifies callers that don't know if the mask bit is set.
> 
> Before:
>   if (valuator_mask_isset(mask, valnum))
>     value = valuator_mask_get_double(mask, valnum));
>   else
>     value = someothervalue;
> 
> Now:
>  if (!valuator_mask_fetch_double(mask, valnum, &value))
>     value = someothervalue;
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

I think this will help clean up code all over :).

Reviewed-by: Chase Douglas <chase.douglas at canonical.com>


More information about the xorg-devel mailing list