答复: [PATCH 3/4]new driver initial patch 3

[Alan Coopersmith]

On 08/ 1/12 03:40 AM, Michal Suchanek wrote:
> You replace copyright notices on files you modify. This is NOT how
> copyright is managed. When you modify a file that you did not write
> you add you name among the author names, ad DO NOT DELETE the names of
> authors of previous revisions of the  file.

Correct, unless you're sure you deleted all their work and nothing remains
that is their work or derived from it.

> I also noticed that all copyright notices in all files are dated (c) 2012.
> 
> For some reason it is a practice to record history of files in the
> copyright notices - eg.
> 
> (c) 2007, 2009-2011 John Doe
> 
> which means that the file was written in 2007 and modified in 2009,
> 2010 and 2011.
> 
> I would be surprised if the driver files you submit in the previous
> patch all just came into existence this year. From this history
> standpoint the copyright notice is inaccurate although you  can
> probably claim you touched all of the files.

Actually, it's typically the dates that something was "published", which
for open source usually means "made public", so if it was developed in
secret for 5 years and only made public in 2012, then a single 2012 date
may be correct.    Some corporate policies also don't include listing all
the intermediate dates, so I wouldn't quibble on that point.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc