[PATCH v2] xf86: Fix non-PCI configuration-less setups

Dave Airlie airlied at gmail.com
Tue Dec 11 17:49:59 PST 2012


So this got merged into Fedora, and nobody reads bug reports after
merging stuff to know when it breaks lots of things.
>      }
>
> +    /*
> +     * If all of the above fails, which can happen if X was started without
> +     * configuration or if BusID wasn't set for non-PCI devices, use the first
> +     * device by default.
> +     */
> +    if (!foundScreen && xf86_num_platform_devices > 0 && numDevs > 0)
> +        foundScreen = probeSingleDevice(&xf86_platform_devices[0], drvp, devList[0], 0);
> +

So this patch doesn't get foundScreen right at all, I've got a fix I'm
just testing now, though it just shows that the code originally was
broken, but we didn't notice!

Dave.


More information about the xorg-devel mailing list