[PULL] early acceptance patches

[Keith Packard]

On Tue, 7 Feb 2012 17:57:47 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:

> Chase Douglas (7):
>       Store window pointer in touch listener record
>       Factor out TouchEnd generation and delivery
>       Export TouchEventRejected as TouchRejected
>       Move AllowTouch to dix/touch.c, and rename to TouchAcceptReject
>       Check for proper window ID when processing touch allow requests
>       Implement early touch reject
>       Implement touch early accept

These have all been reviewed by Peter.

> 
> Peter Hutterer (2):
>       Revert "dix: deduplicate callers of DeliverDeviceEvents in DeliverGrabbedEvents"

This reverts a (failed) attempt to clean up this code.

Reviewed-by: Keith Packard <keithp at keithp.com>

>       Xi: check request size for xXIAllowEvents based on client version

This one looks wrong to me -- xXIAllowEventsReq is 20 bytes long in the
server, so any old clients sending only 12 bytes will get a length
error.

I think the protocol should declare both structures, much as randrproto
does for SetScreenConfig (although, I think that's backwards -- use a
new struct for the new request). Then you can check the size in the
server by comparing with the struct appropriate for the client
version.

You need to also reject old clients that send XIRejectTouch or
XIAcceptTouch values to avoid walking off the end of the request.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120207/0767a21b/attachment.pgp>