[PATCH libXi] Fix bus error on MIPS N32 for bug #38331.

Michał Masłowski mtjm at mtjm.eu
Tue Feb 21 11:43:24 PST 2012


> i think you need the same code in copyDeviceChangedEvent.
>
> looking at this in more detail, I have a few more comments though:
> - adding new classes may make this bug appear again. you could just fix this
>   in sizeDeviceClassType() to ensure we only ever return double-aligned
>   sizes (which would cover copyDeviceChangedEvent as well then).
> - likewise, you could adjust ptr_lib before the switch statement in
>   copy_classes and so something similar in copyDeviceChangedEvent.
>   that too should then future-proof us for new device classes.

Next patch will change sizeDeviceClassType and use it, or new helper
functions, to determine correct block size.  Previously this was
calculated in several places, since sizeDeviceClassType returns a sum of
sizes passed to separate next_block calls.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120221/b5d3a429/attachment.pgp>


More information about the xorg-devel mailing list