[PATCH intel-gpu-tools 00/10] Upgrade module configuration - Part 2

Gaetan Nadon memsize at videotron.ca
Wed Jan 4 06:17:49 PST 2012

On 12-01-03 09:42 PM, Eric Anholt wrote:
> On Mon, 02 Jan 2012 18:23:15 -0500, Gaetan Nadon <memsize at videotron.ca> wrote:
>> This series applies some xorg project policies and code reuse from util-macros.
>> In some cases it reverts "upgrades" that were "too new" for the overall xorg.
>> There were no bug fixes, things went smoothly.
> Both series for updates to automake infrastructure for this project are
> Acked-by: Eric Anholt <eric at anholt.net>
> I think I cribbed from xf86-video-intel when I originally did this
> stuff, and I didn't mean for it to be gratuitously different from our
> other projects, as I recall.
Things evolved gradually over the last 3 years to arrive at the
configuration we have today. I provided explanations so the changes do
not appear to be gratuitous.

I noticed the system_routine configuration is rather convoluted. I
prototyped a formal automake Makefile.am and it simplifies things quite
a bit, all the way up to configure.ac. As it is now, the system_routine
does not build from a tarball due to a missing Makefile.

I'd need a little help to do  a better job. I suppose "sr" is the system
routine, how would this gets used by someone who installed the package
from a distro? I am wondering which files to install from this subdir.

Thanks for the review.

More information about the xorg-devel mailing list