[PATCH 22/31] DIX: _X_UNEXPORT

Daniel Stone daniel at fooishbar.org
Wed Jan 4 15:15:27 PST 2012


Hi,

On Fri, Dec 02, 2011 at 11:32:31AM -0800, Alan Coopersmith wrote:
> On 12/02/11 03:31, Daniel Stone wrote:
> >--- a/dix/dispatch.c
> >+++ b/dix/dispatch.c
> >@@ -167,7 +167,7 @@ static int nextFreeClientID; /* always MIN free client ID */
> >
> >  static int	nClients;	/* number of authorized clients */
> >
> >-CallbackListPtr ClientStateCallback;
> >+_X_EXPORT CallbackListPtr ClientStateCallback;
> 
> That looks like an add, not a remove.   Some reason for that?

I've moved this back to the header and folded dixstruct.h back in, so
the total end result is no change.

> >-extern _X_EXPORT FontPtr find_old_font(XID /*id*/);
> >+extern FontPtr find_old_font(XID /*id*/);
> 
> libXfont appears to try to link with that one (though it has a weak linked stub
> to fallback on so you may not notice right away, especially if you're not using
> the font server).

I've re-exported this now, thanks.

Cheers,
Daniel


More information about the xorg-devel mailing list