[PATCH 00/31] _X_UNEXPORT
daniel at fooishbar.org
Thu Jan 5 07:21:37 PST 2012
On Fri, Dec 02, 2011 at 01:05:43PM -0800, Aaron Plattner wrote:
> Of the symbols removed here, we use the following:
Thanks for this list -- it's great, exactly what I was hoping for. I've
re-exported all these symbols in my current tree, so hopefully it should
> Using "nobody is currently using this interface" as justification for removing something triggers my "that doesn't follow!" reaction, but most of this stuff seems fine. There are some weird things though, like allowing people to call CreatePicture but not ChangePicture.
> If something is unused and it either shouldn't be used or is unlikely to be useful, then I'm all for deleting it.
Yeah, it's a fair shout. A lot of it was semi-automated: I just
generated a massive list of unused symbols and their definition sites,
did a couple of sweeps of manual sanity-checking and culling, but by the
time I'd unexported the millionth symbol, certainly some less sensible
changes may have slipped through the cracks. :)
I'm taking another, closer, look at all the changes before I send out
v3, and will re-export anything I can see -- like ChangePicture -- which
should probably stay ABI.
> Some of these changes could use corresponding changes to doc/Xserver-spec.xml.
Hmm, I don't think either Xserver-spec.xml or ddx-design.xml need
changes, since this only affects Xorg modules; the DIX<->DDX interface
hasn't really changed in any way. Both documents could definitely do
with some love though ...
Thanks again for the review!
More information about the xorg-devel