[PATCH intel-gpu-tools 3/6] lib: simplify makefile
memsize at videotron.ca
Fri Jan 6 14:20:49 PST 2012
On 12-01-06 11:24 AM, Colin Walters wrote:
> On Fri, 2012-01-06 at 10:52 -0500, Gaetan Nadon wrote:
>> Very little has changed in this one.
> Your commit message isn't helpful - *what* are you simplifying? In this
> case it looks like you're e.g. putting -I directives in CPPFLAGS, using
> the common $(DRM_CFLAGS), and alphabetizing the sources. Say so then,
> something like:
> lib: Fix include directives, alphabetize sources
> -I should go in AM_CPPFLAGS.
You are absolutely right, I got lazy. I'll review all of them.
More information about the xorg-devel