[Intel-gfx] [PATCH] Android port of intel-gpu-tools

Daniel Vetter daniel at ffwll.ch
Tue Jan 10 04:47:52 PST 2012

On Tue, Jan 10, 2012 at 10:15:01AM +0530, Sateesh Kavuri wrote:
> Added support for Android. Changes include fixes for compilation issues
>  related to Android using an older version of GCC compiler (ver 4.3.3)
>  while the latest version of intel-gpu-tools confirms to GCC ver 4.5.2
>  (C99 standard functions), using functions like getline(). Fixed such
>  functions, header dependencies for android and added an Android.mk file.
> signed-off-by: Sateesh Kavuri <sateesh.kavuri at intel.com>

A few comments
- It looks like you need a completely separate makefile for android. Is
  there no way to let the automake tools generate that somehow? Because
  this simply won't scale.

- There's too much ANDRIOD #ifdef'ery in the code. Either switch to a
  construct that works on all platforms or extract things into a little
  helper functions (like the get_total_ram helper that has recently been
  ported to Solaris).

- You don't seem to touch the testsuite, and I think you want it on
  Andriod, too.

Added xorg-devel to cc, maybe someone else has already tried this with a
different package, my buildsystem fu is not up to this.

Yours, Daniel
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48

More information about the xorg-devel mailing list