[PATCH xf86-input-evdev 1/2] Re-indent: put '{' on new line

Peter Hutterer peter.hutterer at who-t.net
Wed Jan 18 16:29:14 PST 2012

On Thu, Jan 19, 2012 at 01:23:19AM +0100, Chase Douglas wrote:
> On 01/19/2012 01:21 AM, Peter Hutterer wrote:
> > On Thu, Jan 12, 2012 at 04:00:32PM +0100, Chase Douglas wrote:
> >> Signed-off-by: Chase Douglas <chase.douglas at canonical.com>
> > 
> > did you run ident or something to get this? it doesn't apply cleanly but if
> > it's just a ident line it'd be easy enough to reproduce.
> I started with master, so I don't know why it doesn't apply cleanly...

I applied out-of-order, the force x/y patches went in since and they mess
things up. my fault, sorry. 

for large-scale code formatting patches, it's usually a good idea
to halt development for a bit so everyone can rebase. sorry, been preempted
so I didn't get to this earlier.
> I did it with a vim replace. Multiline statements are manually fixed.
> > also, given daniels' patch on the xserver, it might be a good idea to just
> > use the same ident option as the server.
> Yeah, that's not a bad idea. However, that's still in flux. Would it be
> better to skip this patch for now and refresh the original "copy
> valuators" patch with the few trivial fixes?

yeah, let's get the actual fix in and worry about ident later. I'll review
the last patch for code only, then we can merge it once it applies again.


More information about the xorg-devel mailing list