[PATCH 1.12] A coding style for the server

Keith Packard keithp at keithp.com
Wed Jan 18 16:29:43 PST 2012

On Wed, 18 Jan 2012 20:42:43 +0100, Chase Douglas <chase.douglas at canonical.com> wrote:

> 1. Should we just go with linux style, so we can use check_patch without
> any modifications?
> 2. If not, will we fork check_patch or make our own?

I'd be good with either plan. I can also run check_patch on anything
getting added to the server, with suitable nag mails for patches which
don't pass.

> 3. Who will enforce style? I believe if we have a script we can add a
> commit hook to the git server, but that may be too heavy-handed.

It wouldn't be hard for me to make that part of the regular patch
merging process

> 4. If no one will enforce style, do we want to periodically run indent
> to fix things. Maybe once per cycle after the merge window closes (as
> you suggest here, but I begged for mercy against this time :)?

No, once will be painful enough. After that, all new patches would be
required to follow the formatting conventions or not get accepted.

Keeping the code correct at all times makes it easier to fix new code --
just re-indent all changed files.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120118/9a9e9a0c/attachment.pgp>

More information about the xorg-devel mailing list