[PATCH modular] Per-component configure options

Gaetan Nadon memsize at videotron.ca
Wed Jan 18 16:49:36 PST 2012


On 12-01-16 06:22 PM, Trevor Woerner wrote:
> @@ -1009,9 +1017,15 @@ process_module_file() {
>  	    continue
>  	fi
>  
> -	module=`echo $line | cut -d'/' -f1`
> -	component=`echo $line | cut -d'/' -f2`
> -	build $module $component
> +	module=`echo $line | cut -d' ' -f1 | cut -d'/' -f1`
> +	component=`echo $line | cut -d' ' -f1 | cut -d'/' -f2`
> +	confopts_check=`echo $line | cut -d' ' -f2-`
What is the role of the dash following f2? There were none before.
> +	if [ "$module/$component" = "$confopts_check" ]; then
> +	    confopts=""
> +	else
> +	    confopts="$confopts_check"
> +	fi
> +	build $module "$component" "$confopts"
>      done <"$MODFILE"
Are all the new quotes around "$component" required? There can be no
spaces in the lines, e.g. app/xclock. The seperator is a space and a
'/'. Many double quotes have been added throughout the script.


More information about the xorg-devel mailing list