Possible revert before the next tag

Jeremy Huddleston jeremyhu at apple.com
Tue Jan 31 11:03:03 PST 2012


I reverted this from the 1.11 branch due to a regression back on November 3, but it is still on master with the regression unaddressed.  I'd like to revert it from master if we're unable to figure out the cause of the regression.

The use case which shows the problem is running "Worms 2" in wine, but I am unsure if it reproduces outside of XQuartz.  It's possible that our use of XIModeAbsolute is relevant here...

commit 2bfb802839688ecf328119c4c6979390fc60348d
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Fri Jul 29 16:33:54 2011 +1000

    dix: don't XWarpPointer through the last slave anymore (#38313)
    This line was introduced pre-1.6 to fix Bug 19297. The effect of warping
    through the VCP then was that if a device had custom valuator ranges, the
    warp position would be wrong. The better device for this effect is the the
    XTest device.
    This fixes a server crash where the lastSlave is a pointer device without
    valuators (Bug 38313#0).
    And while we're at it, make sure the Xinerama code-path does the same.
    X.Org Bug 38313 <http://bugs.freedesktop.org/show_bug.cgi?id=38313>
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    Reviewed-by: Daniel Stone <daniel at fooishbar.org>

More information about the xorg-devel mailing list