[PATCH xorg-server] Fix xf86EdidModes.c: array subscript is above array bounds

Adam Jackson ajax at redhat.com
Fri Jul 6 08:50:28 PDT 2012


On 7/5/12 7:37 PM, Keith Packard wrote:
> Torsten Kaiser<just.for.lkml at googlemail.com>  writes:
>
>> With this optimization level gcc notices, that the loop in function
>> DDCModesFromEstIII() would go until i=5 and j=1 which would result in
>> m = (5 * 8) + (7 - 1) = 46, but the array EstIIIModes[] only contains
>> 44 elements.
>
> I'd like Adam's opinion; he wrote the original code and is the best
> person to verify that this does what the spec requires. On the face of
> it, it looks right to me though...

I've added my r-b to the patches on

https://bugs.freedesktop.org/45623

- ajax


More information about the xorg-devel mailing list