[PATCH modesetting] Implement ->driverFunc

[Aaron Plattner]

On 07/20/2012 03:28 PM, Adam Jackson wrote:
> On 7/20/12 3:44 PM, Aaron Plattner wrote:
>> On 07/19/2012 03:15 PM, Adam Jackson wrote:
>>> +static Bool
>>> +ms_driver_func(ScrnInfoPtr scrn, xorgDriverFuncOp op, void *data)
>>> +{
>>> +    xorgHWFlags *flag;
>>> +
>>> +    switch (op) {
>>> +    case GET_REQUIRED_HW_INTERFACES:
>>> +        flag = (CARD32 *)data;
>>> +        (*flag) = 0;
>>
>> Should this be = 0, or &= ~HW_IO?
>
> It should not be ~HW_IO, since that would set HW_SKIP_CONSOLE, which we
> don't want.

&=, not =.  I.e.,

  *flag = *flag & ~HW_IO.

I.e. just clear the HW_IO bit and leave the rest alone, rather than clear all of 
them.

> It would also set HW_MMIO; somewhat bizarrely that flag has never been
> interpreted by the server to mean anything, even in the initial commit.

Just setting it to 0 will also clear any future on-by-default flags that we 
might want to add.

-- Aaron