[PATCH] xkb: warn if XKB SlowKeys have been automatically enabled

[Dan Nicholson]

On Tue, Jun 5, 2012 at 9:57 PM, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> Slow keys are enabled when the XKB AccessX features are generally enabled
> (ctrls->enabled_ctrls & XkbAccessXKeysMask) and either shift key is held for
> 8 seconds. For the unsuspecting user this appears as if the keyboard
> suddenly stops working.
>
> Print a warning to the log, so we can later tell them "told you so".
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  xkb/xkbAccessX.c |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/xkb/xkbAccessX.c b/xkb/xkbAccessX.c
> index 95e28e7..fe28e12 100644
> --- a/xkb/xkbAccessX.c
> +++ b/xkb/xkbAccessX.c
> @@ -295,10 +295,15 @@ AccessXKRGExpire(OsTimerPtr timer, CARD32 now, pointer arg)
>     cn.eventType = 0;
>     cn.requestMajor = 0;
>     cn.requestMinor = 0;
> -    if (xkbi->desc->ctrls->enabled_ctrls & XkbSlowKeysMask)
> +    if (xkbi->desc->ctrls->enabled_ctrls & XkbSlowKeysMask) {
>         AccessXKRGTurnOff((DeviceIntPtr) arg, &cn);
> -    else
> +        LogMessage(X_INFO, "XKB SlowKeys are disabled.\n");
> +    }
> +    else {
>         AccessXKRGTurnOn((DeviceIntPtr) arg, XkbSlowKeysMask, &cn);
> +        LogMessage(X_INFO, "XKB SlowKeys are now enabled. Hold shift to disable.\n");
> +    }
> +
>     return 0;
>  }
>

I never knew about that. Seems like exactly the type of feature to be
buried deep in the server...

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>