No subject

needed to build from source. It's not part of the GNU build system
architecture. It's a legacy script from the days where autoreconf did
not exist and a handful of commands had to be submitted every time.
</pre>
      </blockquote>
      <pre wrap="">
So, a few months later...any further thoughts on this?  Anything I can
do to help?

I know it's a trivial thing, but I've made a lot of progress in
standardizing the build-from-git across many modules in the stack now,
and X.org definitely stands out in sheer module count =)




</pre>
    </blockquote>
    <br>
    I have kept thinking about it since then. The changes to the script
    are ok, but if the whole point of installing a copy through
    util-macros was to save patch work for the future, having an "else"
    part defeats the purpose. In the future, we would end up with
    (potentially) two different behaviours depending if the script was
    installed or if the "else" part was used.<br>
    <br>
    I'd rather have a script change only and drop the "install through
    util-macros" part. This will reduce the overall complexity and
    reduce the number of places to investigate when things go wrong.
    Changes to the script are likely to be several years apart. <br>
    <br>
    If I had time to implement this project, I would have included a
    patch from Roland Mainz which add quotes to support directories
    containing spaces. I cannot locate the patch itself, but I wrote a
    note as to where the quotes were added:<br>
    <br>
    <blockquote><tt>#! /bin/sh</tt><br>
      <br>
      <tt>srcdir=`dirname "$0"`</tt><br>
      <tt>test -z "$srcdir" &amp;&amp; srcdir=.        &lt;===</tt><br>
      <br>
      <tt>ORIGDIR=`pwd`</tt><br>
      <tt>cd "$srcdir"Â Â Â  Â Â Â  Â Â Â  Â Â Â  &lt;===</tt><br>
      <br>
      <tt>autoreconf -v --install || exit 1</tt><br>
      <tt>cd "$ORIGDIR" || exit $?        &lt;=====</tt><br>
      <br>
      <tt>"$srcdir/configure" --enable-maintainer-mode "$@"Â Â Â  &lt;=====</tt><br>
      <tt>|-----------------|&lt;=====</tt><tt></tt><br>
      <br>
      <tt>Roland Mainz wrote:</tt><br>
      <tt>Note the issue mainly applies to users on Windows which use</tt><br>
      <tt>environments like Cygwin, UWIN, SFU etc. where user homedirs
        very</tt><br>
      <tt>often have whitespaces etc. in the name of their home
        directory.</tt><br>
    </blockquote>
    A note about <a class="moz-txt-link-freetext" href="http://cgit.freedesktop.org/xorg/test/xorg-gtest/">http://cgit.freedesktop.org/xorg/test/xorg-gtest/</a>. This
    module has a different script (the only one so far) which never runs
    ./configure. Chase Douglas is actively maintaining this module. The
    new script you are proposing might just well be what he was waiting
    for.<br>
    <br>
    Overall there are about 240 modules that are being published at
    different intervals. The list can be obtained by running
    modular/build.sh -L.<br>
    <br>
    If you post the revised patch, I'll be happy to review it. <br>
    <br>
    <br>
    <br>
    <br>
    <br>
    <br>
    <br>
    <br>
    <br>
  </body>
</html>

--Boundary_(ID_sj6r1l6MtZBvuGDPBHl5aA)--