[RFC PATCH:xf86-video-ati 9/15] Link with modules needed to build with no-undefined linking

Alan Coopersmith alan.coopersmith at oracle.com
Mon Jun 11 18:36:21 PDT 2012


On 06/ 1/12 02:56 AM, Michel Dänzer wrote:
> On Fre, 2012-05-25 at 08:02 -0700, Alan Coopersmith wrote: 
>> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>> ---
>>  src/Makefile.am |   13 +++++++++++--
>>  1 file changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index dc77c02..4357135 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -26,11 +26,12 @@
>>  # _ladir passes a dummy rpath to libtool so the thing will actually link
>>  # TODO: -nostdlib/-Bstatic/-lgcc platform magic, not installing the .a, etc.
>>  
>> -radeon_drv_la_LIBADD = $(LIBDRM_RADEON_LIBS)
>> +radeon_drv_la_LIBADD = $(LIBDRM_RADEON_LIBS) $(XORG_LIBS) -lpixman-1 -lm
> 
> The driver doesn't depend on pixman directly, does it? I'd prefer that
> to be inherited from xserver somehow. If it isn't covered by -lfb
> anyway, that is.

It does, thanks to the fb macros that now implement region operations using
pixman functions - nm on radeon_drv.so here shows it calling:

pixman_region_copy
pixman_region_equal
pixman_region_subtract
pixman_region_union

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list