[PATCH 04/14] xfree86: add DDX gpu screen support. (v2)

[Keith Packard]

Dave Airlie <airlied at gmail.com> writes:

> +    pScrn->origIndex = pScrn->scrnIndex;      /* This never changes */

I can't find any users of origIndex; I suspect it can be safely removed.

> -    xf86Screens[i]->drv = drv;
> +    pScrn->drv = drv;
>      drv->refCount++;
> -    xf86Screens[i]->module = DuplicateModule(drv->module, NULL);
> +    pScrn->module = DuplicateModule(drv->module, NULL);
>  
> -    xf86Screens[i]->DriverFunc = drv->driverFunc;
> +    pScrn->DriverFunc = drv->driverFunc;
>  
> -    return xf86Screens[i];
> +    return pScrn;
>  }

bikeshed -- would it be better to clean up the xf86Screens[i] usage
before adding gpu screen support?

Otherwise, this one looks good to me

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120620/e82ba032/attachment-0001.pgp>