[PATCH v2] os: print newline after printing display name

Chase Douglas chase.douglas at canonical.com
Thu Jun 21 07:23:38 PDT 2012


On 06/20/2012 10:30 PM, Peter Hutterer wrote:
> Much easier for scripts that try to read the display value off the file
> descriptor. Plus, this restores the behaviour we had for this patch in
> Fedora since server 1.6 (April 2009).
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

I didn't see why the '\n' was useful when I proposed the functionality.
I see that it makes it hard to use it with scripts. Makes sense to me.

Reviewed-by: Chase Douglas <chase.douglas at canonical.com>

> ---
> alanc pointed me to why the \n wasn't part of dynamic_display, thanks.
> See http://patchwork.freedesktop.org/patch/9740/ for Jon's original comment.
> 
> Changes to v1:
> - don't store \n in dynamic_display, just write it out instead
> 
>  os/connection.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/os/connection.c b/os/connection.c
> index 039942f..3441472 100644
> --- a/os/connection.c
> +++ b/os/connection.c
> @@ -353,6 +353,7 @@ NotifyParentProcess(void)
>  #if !defined(WIN32)
>      if (dynamic_display[0]) {
>          write(displayfd, dynamic_display, strlen(dynamic_display));
> +        write(displayfd, "\n", 1);
>          close(displayfd);
>      }
>      if (RunFromSmartParent) {



More information about the xorg-devel mailing list