[PATCH] xkb: fill in keycode and event type for slow keys enablement

Daniel Stone daniel at fooishbar.org
Mon Jun 25 01:56:54 PDT 2012


Hi,

On 25 June 2012 03:16, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> @@ -462,15 +469,18 @@ AccessXFilterPressEvent(DeviceEvent *event, DeviceIntPtr keybd)
>     if (ctrls->enabled_ctrls & XkbAccessXKeysMask) {
>         /* check for magic sequences */
>         if ((sym[0] == XK_Shift_R) || (sym[0] == XK_Shift_L)) {
> +            struct slow_keys_enable_t *ske = malloc(sizeof(*ske));
> +            ske->keybd = keybd;
> +            ske->key = key;

This would probably be best off as a static in SrvXkbInfoRec to avoid
allocating one for every press of shift ... other than that, looks
fine to me.

Acked-by: Daniel Stone <daniel at fooishbar.org>

Cheers,
Daniel


More information about the xorg-devel mailing list