[PATCH libXaw3d] Fix ... ?

Jeremy Huddleston jeremyhu at apple.com
Wed Mar 14 17:39:59 PDT 2012


Looks like it does the right thing

Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

On Mar 14, 2012, at 10:14 AM, Matt Turner <mattst88 at gmail.com> wrote:

> Found at http://gitorious.org/xaw3d/xaw3d/commit/bef54db66ae333f2e741186ca423325d17c58eb9
> 
> Same fix appeared in libXaw as part of XFree86 4.3.0.1.
> 
> XFree86's CVS says 'fix-trackers 3637-3977' for this change,
> but I have no idea what those numbers correspond to.
> 
> http://cvsweb.xfree86.org/cvsweb/xc/lib/Xaw/MultiSrc.c.diff?r1=1.1&r2=1.2
> 
> Signed-off-by: Matt Turner <mattst88 at gmail.com>
> ---
> I don't know what this actually fixes.
> 
> src/MultiSrc.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/MultiSrc.c b/src/MultiSrc.c
> index b53fa50..1ac3283 100644
> --- a/src/MultiSrc.c
> +++ b/src/MultiSrc.c
> @@ -728,6 +728,7 @@ SetValues(Widget current, Widget request, Widget new, ArgList args, Cardinal *nu
> 
>   if ( string_set || (old_src->multi_src.type != src->multi_src.type) ) {
>     RemoveOldStringOrFile(old_src, string_set);
> +    src->multi_src.allocated_string = old_src->multi_src.allocated_string;
>     file = InitStringOrFile(src, string_set);
> 
>     /* Load pieces does this logic for us, but it shouldn't.  Its messy.*/
> -- 
> 1.7.3.4
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
> 



More information about the xorg-devel mailing list