Re: [PATCH] Added an xorg configuration file snippet to disable grabbing of virtual test devices. Signed-off-by: Thomas Voß <tvoss at tvoss-ThinkPad-X121e.(none)>

[Chase Douglas]

On 03/22/2012 11:59 AM, thomas.voss at canonical.com wrote:
> From: Thomas Voß <tvoss at tvoss-ThinkPad-X121e.(none)>

Looks like your email wasn't formatted properly :). I'm guessing you
were missing a newline between the subject and the commit message. You
also need to set your email address in ~/.gitconfig.

I can fix these issues up on my end for this commit.

> ---
>  data/Makefile.am                                  |    2 +-
>  data/X11/xorg.conf.d/99-virtual-test-devices.conf |    4 ++++
>  2 files changed, 5 insertions(+), 1 deletions(-)
>  create mode 100644 data/X11/xorg.conf.d/99-virtual-test-devices.conf
> 
> diff --git a/data/Makefile.am b/data/Makefile.am
> index bf74a73..b90179a 100644
> --- a/data/Makefile.am
> +++ b/data/Makefile.am
> @@ -23,4 +23,4 @@
>  # SOFTWARE.
>  #
>  
> -nobase_data_DATA = xorg/gtest/dummy.conf
> +nobase_data_DATA = xorg/gtest/dummy.conf X11/xorg.conf.d/99-virtual-test-device.conf
> diff --git a/data/X11/xorg.conf.d/99-virtual-test-devices.conf b/data/X11/xorg.conf.d/99-virtual-test-devices.conf
> new file mode 100644
> index 0000000..2d712a4
> --- /dev/null
> +++ b/data/X11/xorg.conf.d/99-virtual-test-devices.conf
> @@ -0,0 +1,4 @@
> +Section "InputClass"
> +         MatchProduct "Virtual Test Device"
> +         Option "GrabEventDevice" "false"
> +EndSection

Looks good to me.

Reviewed-by: Chase Douglas <chase.douglas at canonical.com>

Peter, does this look good to you too?