[PATCH 2/2] xfree86: use udev to provide device enumeration for kms devices

Dave Airlie airlied at gmail.com
Tue May 8 12:34:04 PDT 2012


On Tue, May 8, 2012 at 7:12 PM, Dave Airlie <airlied at gmail.com> wrote:
> On Tue, May 8, 2012 at 6:54 PM, Adam Jackson <ajax at nwnk.net> wrote:
>> On 5/8/12 9:40 AM, Dave Airlie wrote:
>>
>>> On Linux in order for future hotplug work, we are required to interface
>>> to udev to detect device creation/removal. In order to try and get
>>> some earlier testing on this, this patch adds the ability to use
>>> udev for device enumeration on Linux.
>>
>>
>> The big thing I don't really like about this patch is how it talks about
>> udev so much.  The driver hook should be platformProbe or osProbe or
>> something instead, and the fact that it's udev on Linux is just an OS
>> detail.

I've thought about this some more and I can't come up with anything
sensible with a generic interface.

The info we need to pass the drivers to probe is os-specific info, I
don't see the point of a generic interface
that is passing non-generic information into drivers. Like look at the
contents of xf86_udev_device, what
in there isn't udev specific? what info should be in there that
another OS would need etc.

Like yes we could rewrite the whole lot, but I don't want another
pciaccess, evolution already, not rewrite and break.

Dave.


More information about the xorg-devel mailing list