[PATCH] dix: disable all devices before shutdown

Peter Hutterer peter.hutterer at who-t.net
Wed May 9 15:24:08 PDT 2012


On Wed, May 09, 2012 at 09:31:23PM +0200, Julien Cristau wrote:
> On Wed, May  9, 2012 at 09:26:00 +1000, Peter Hutterer wrote:
> 
> > f3410b97cf9b48a47bee3d15d232f8a88e75f4ef introduced a regression on server
> > shutdown. If any button or key was held on shutdown (ctrl, alt, backspace
> > are usually still down) sending a raw event will segfault the server. The
> > the root windows are set to NULL before calling CloseDownDevices().
> > 
> > Avoid this by disabling all devices first when shutting down. Disabled
> > devices won't send events anymore.
> > 
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> > ---
> >  dix/devices.c   |   15 +++++++++++++++
> >  dix/main.c      |    4 ++++
> >  include/input.h |    2 +-
> >  3 files changed, 20 insertions(+), 1 deletion(-)
> > 
> One of the people who reported the corresponding debian bug says this
> fixes the crash, but he gets "[dix] cannot disable device, still paired.
> This is a bug." twice on shutdown now.  Not sure if this is expected?

I'll have a look, didn't see that message yesterday but I know where it
comes from.

Cheers,
  Peter


More information about the xorg-devel mailing list