[PATCH 13/19] xserver: drop index argument to ScreenInit (ABI/API)

Alan Coopersmith alan.coopersmith at oracle.com
Mon May 14 14:04:51 PDT 2012


On 05/14/12 09:41 AM, Dave Airlie wrote:
> This drops the index argument, its the same as pScreen->myNum,
> and its the last major index abuse I can find.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  dix/dispatch.c               |    5 ++---
>  hw/dmx/dmxextension.c        |    2 +-
>  hw/dmx/dmxscrinit.c          |   16 ++++++++--------
>  hw/dmx/dmxscrinit.h          |    4 ++--
>  hw/kdrive/src/kdrive.c       |    2 +-
>  hw/kdrive/src/kdrive.h       |    2 +-
>  hw/vfb/InitOutput.c          |    4 ++--
>  hw/xfree86/common/xf86str.h  |    2 +-
>  hw/xfree86/doc/ddxDesign.xml |    2 +-
>  hw/xwin/winscrinit.c         |    8 ++++----
>  include/screenint.h          |    1 -
>  11 files changed, 23 insertions(+), 25 deletions(-)

You seem to be missing a couple DDX'es that call AddScreen with
a screen init function that needs updating, such as:
	hw/xnest/Screen.c:	xnestOpenScreen()
	hw/xwin/winscrinit.c:	winScreenInit()
	hw/xquartz/darwin.c:    DarwinScreenInit()

Also the description of the scrInitProc passed to AddScreen in
doc/Xserver-spec.xml needs updating to match.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list