[PATCH 1/2 v2] dri2proto: Add DRI2GetParam request

Alan Coopersmith alan.coopersmith at oracle.com
Tue May 15 19:03:06 PDT 2012


On 05/15/12 05:19 PM, Chad Versace wrote:
>> Where will the master list of these be maintained to avoid conflicts?   Server
>> ones in dri2proto.txt/dri2proto.h and driver ones in each driver's headers?
> That is the plan; sorry for not documenting that. I will explicitly
> document that in dri2proto.txt in v3.

You might look at how RandR defines known & mandatory properties in its
protocol spec to see if a similar sort of listing makes sense:
http://www.x.org/releases/X11R7.7-RC1/doc/randrproto/randrproto.txt

> Ah, this is my first time working the X protocol. I was unaware that
> it was legal to pack data into the packet header. I'll do this in v3.

If you look through the core protocol you'll see that padding byte is
used for replies that have a byte-sized member that can fit in nicely
there - but many don't, leaving it unused.

http://www.x.org/releases/X11R7.7-RC1/doc/xproto/x11protocol.html#Encoding::Requests

I don't see any other DRI2 replies with a single byte value to return,
which is probably why it's unused in all the existing ones in that
extension protocol, but you can see some RandR replies do use it.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list