[PATCH v3 02/02] dri2: Add DRI2GetParam request

Eric Anholt eric at anholt.net
Thu May 17 11:02:23 PDT 2012


On Wed, 16 May 2012 12:44:41 -0700, Chad Versace <chad.versace at linux.intel.com> wr> diff --git a/hw/xfree86/dri2/dri2ext.c b/hw/xfree86/dri2/dri2ext.c
> index 2579a5c..5487806 100644
> --- a/hw/xfree86/dri2/dri2ext.c
> +++ b/hw/xfree86/dri2/dri2ext.c
> @@ -535,6 +535,38 @@ ProcDRI2WaitSBC(ClientPtr client)
>  }
>  
>  static int
> +ProcDRI2GetParam(ClientPtr client)
> +{
> +    REQUEST(xDRI2GetParamReq);
> +    xDRI2GetParamReply rep;
> +    DrawablePtr pDrawable;
> +    CARD64 param;

Unused variable?

> +    CARD64 value;
> +    int status;
> +
> +    REQUEST_SIZE_MATCH(xDRI2GetParamReq);
> +    rep.type = X_Reply;
> +    rep.length = 0;
> +    rep.sequenceNumber = client->sequence;
> +
> +    if (!validDrawable(client, stuff->drawable, DixReadAccess,
> +                       &pDrawable, &status))
> +        return status;
> +
> +    status = DRI2GetParam(client, pDrawable, stuff->param,
> +                          &rep.is_param_recognized, &value);
> +    rep.value_hi = value >> 32;
> +    rep.value_lo = value & 0xffffffff;
> +
> +    if (status != Success)
> +        return status;
> +
> +    WriteToClient(client, sizeof(xDRI2GetParamReply), &rep);
> +
> +    return status;
> +}

Other than that, this series is:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120517/22eb7f7a/attachment-0001.pgp>


More information about the xorg-devel mailing list