[PATCH libxcwm 11/15] Fix parameter transposition in xcwm_window_configure()

Jon TURNEY jon.turney at dronecode.org.uk
Mon Nov 5 14:50:12 PST 2012


xcwm_window_configure() has width and height parameters in the opposite order to
the order used everywhere else.

Signed-off-by: Jon TURNEY <jon.turney at dronecode.org.uk>
---
 include/xcwm/window.h     |    2 +-
 src/libxcwm/window.c      |    2 +-
 src/xtoq/XtoqController.m |    6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/xcwm/window.h b/include/xcwm/window.h
index 95c3ff5..4890ca4 100644
--- a/include/xcwm/window.h
+++ b/include/xcwm/window.h
@@ -150,7 +150,7 @@ xcwm_window_request_close(xcwm_window_t *window);
  */
 void
 xcwm_window_configure(xcwm_window_t *window, int x, int y,
-                      int height, int width);
+                      int width, int height);
 
 /**
  * Get the window's type.
diff --git a/src/libxcwm/window.c b/src/libxcwm/window.c
index 4b24be5..308830c 100644
--- a/src/libxcwm/window.c
+++ b/src/libxcwm/window.c
@@ -188,7 +188,7 @@ _xcwm_window_remove(xcb_connection_t *conn, xcb_window_t window)
 
 void
 xcwm_window_configure(xcwm_window_t *window, int x, int y,
-                      int height, int width)
+                      int width, int height)
 {
 
     /* Set values for xcwm_window_t */
diff --git a/src/xtoq/XtoqController.m b/src/xtoq/XtoqController.m
index c6bc564..a092f39 100644
--- a/src/xtoq/XtoqController.m
+++ b/src/xtoq/XtoqController.m
@@ -458,8 +458,8 @@
         // Move the window down by the height of the OSX menu bar
         xcwm_window_configure(window, windowSize->x,
                               windowSize->y - WINDOWBAR,
-                              windowSize->height,
-                              windowSize->width);
+                              windowSize->width,
+                              windowSize->height);
     }
     
     newWindow = [[XtoqWindow alloc]
@@ -580,7 +580,7 @@
         int height = (int)moveFrame.size.height - WINDOWBAR;
 
         xcwm_window_configure(window,
-                              x, y - height, height, width);
+                              x, y - height, width, height);
         [[moveWindow contentView] setNeedsDisplay: YES];
     }
 }
-- 
1.7.9



More information about the xorg-devel mailing list