[PATCH] Xi: don't deliver TouchEnd to a client waiting for TouchBegin (#55738)

Thomas Jaeger thjaeger at gmail.com
Fri Nov 9 10:09:15 PST 2012


On 11/07/2012 07:51 PM, Peter Hutterer wrote:
> On Sun, Oct 28, 2012 at 03:51:15AM -0400, Thomas Jaeger wrote:
>> On 10/18/2012 08:57 PM, Peter Hutterer wrote:
>>> If a client is still waiting for the TouchBegin, don't deliver a TouchEnd
>>> event.
>>>
>>> X.Org Bug 55738 <http://bugs.freedesktop.org/show_bug.cgi?id=55738>
>>>
>>> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
>>> ---
>>>  Xi/exevents.c | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>
>> It appears that under certain circumstances this leads to the matching
>> TouchEnd for a TouchBegin never to be reported, but I don't understand
>> exactly when this happens and I haven't been able to come up with a
>> reproducible test case.  I wish I understood how firefox handles clicks
>> on a bookmark menu folder, since this seems to be related to many of the
>> problems I'm encountering.
>> I'll keep you posted if I find out more.
> 11 -> 2
TouchEnd
> do you have any updates on this? specifically, with carlo's patches in the
> tree now and your patch series for high-res devices on top, do you still see
> this issue?

After a lot of going back and forth between X servers with or without
the patch, I think this particular issue might be gone (but I do have to
admit that I forgot what under exactly what circumstances this
happened).  In either case, I can pretty easily back myself into a
corner where gtk2 apps don't receive any emulated pointer events when
there's a touch grab that rejects touches.  The problem is, of course,
that I don't have any reproducible test cases.

Tom


More information about the xorg-devel mailing list