[PATCH] libXt: util: don't link makestrs with target cflags

Jon TURNEY jon.turney at dronecode.org.uk
Wed Nov 21 06:19:53 PST 2012

On 19/11/2012 22:46, Thomas Petazzoni wrote:
> Hello,
> Anyone for this basic libXt patch?
> Thanks,
> Thomas
> On Fri, 16 Nov 2012 10:41:06 +0100, Thomas Petazzoni wrote:
>> The line:
>> in util/Makefile.am is wrong because it adds target cflags to the
>> compilation of makestrs, which is built for the build machine, which
>> leads to build failures when cross-compiling.
>> We also remove the inclusion of <X11/Xos.h> from makestrs.c, because
>> it was the only non-standard header being included (and therefore
>> possibly requiring special cflags), but it was in reality not useful
>> at all to build makestrs.c.

It was useful in including string.h, and hence preventing a load of warnings
:-), so perhaps you could include that instead.

I'm not sure I totally buy your reasoning, as X11/Xos.h might be doing
something necessary on some obscure platform.

Does makekeys in libX11 present similar problems?

More information about the xorg-devel mailing list