[PATCH] configure: Stop using AM_MAINTAINER_MODE

Gaetan Nadon memsize at videotron.ca
Mon Oct 1 17:16:54 PDT 2012


On 12-09-27 05:12 PM, Adam Jackson wrote:
> All this does is make it so editing configure.ac or Makefile.am doesn't
> rebuild the makefiles.  Which is just stupid.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  configure.ac | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index ac3bf26..b37e608 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -31,7 +31,6 @@ RELEASE_DATE="2012-09-05"
>  RELEASE_NAME="Iced Tea"
>  AC_CONFIG_SRCDIR([Makefile.am])
>  AM_INIT_AUTOMAKE([foreign dist-bzip2])
> -AM_MAINTAINER_MODE
>  
>  # Require xorg-macros minimum of 1.14 for XORG_COMPILER_BRAND in XORG_DEFAULT_OPTIONS
>  m4_ifndef([XORG_MACROS_VERSION],

This is the right thing to do. A couple of improvements:

  * A more technical explanation in the commit text. I like to refer to
    the AM_MAINTAINER mode as a "CVS timestamp losssage workaround". The
    full background can be found here:

    http://lists.gnu.org/archive/html/automake/2003-02/msg00036.html

  * The autogen.sh file must be changed to remove the
    --enable-maintainer-mode parameter which belongs to
    AM_MAINTAINER_MODE. Otherwise you get:

    configure: WARNING: unrecognized options: --enable-maintainer-mode

In essence we are removing configuration code which was put in place as
a work around to a CVS behaviour which caused the downloaded tar file
content to always be out-of-date and rebuilt. This workaround is no
longer required, if it ever has been.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20121001/3d9d2b4e/attachment.html>


More information about the xorg-devel mailing list