[PATCH lib/libXfont] Provide a dummy readlink on WIN32

Jon TURNEY jon.turney at dronecode.org.uk
Mon Oct 29 05:38:48 PDT 2012


On 22/10/2012 18:45, Yaakov (Cygwin/X) wrote:
> On Mon, 2012-10-22 at 16:07 +0100, Jon TURNEY wrote:
>> Provide a dummy readlink, which just returns the supplied path name, on WIN32
> 
> This compiles, but does this really make sense?  Catalogues are managed
> with symlinks, which exist on Windows only in later versions and even
> then aren't POSIXy.  I wonder if catalogues are even used by Win32 X
> servers.  Colin?

On re-reading 'man Xserver', the point I had failed to grasp is that only
symlinks in the catalogue fontpath are considered (so copies, hard links or
native links are all ignored)

In which case, this patch is wrong and a stub readlink() which always returns
the error EINVAL (which shouild be functionally equivalent to Colin's patch
which just skips reading the directory contents) would be more correct.

Alternatively, I suppose it might make sense to add some sort of configure
option to disable building with catalogue fontpath support, so that an error
would be generated if an attempt was made to use one?



More information about the xorg-devel mailing list