[PATCH RESEND] parser: handle negative numbers properly
keithp at keithp.com
Mon Apr 8 11:22:41 PDT 2013
Robert Morell <rmorell at nvidia.com> writes:
> Numbers beginning with '-' were falling into the DASH category.
Yeah, but you're breaking the parsing of sync intervals which use NUMBER
DASH NUMBER. You can fix this in two ways -- use your current hack to
glue the '-' to the following number and then go fix the sync interval
parsing to handle negative numbers, or fix the places where a negative
number is valid to handle DASH NUMBER as well as just NUMBER.
Can you briefly enumerate where negative numbers are valid in the config file?
> This also caused a confusing error message, since no terminating NUL
> character was added to configRBuf -- old garbage in the string would be
> printed. This fixes the terminating NUL for COMMA as well.
Nice fix there.
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 827 bytes
Desc: not available
More information about the xorg-devel