[PATCH] hw/xfree86: Only report SetDesiredModes() failed if at least one modeset fails

Chris Wilson chris at chris-wilson.co.uk
Mon Apr 29 08:34:39 PDT 2013

On Wed, Jan 09, 2013 at 10:33:34PM -0800, Keith Packard wrote:
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> > commit 6703a7c7cf1a349c137e247a0c8eb462ff7b07be
> > Author: Keith Packard <keithp at keithp.com>
> > Date:   Tue Jan 8 20:24:32 2013 -0800
> >
> >     hw/xfree86: Require only one working CRTC to start the server.
> >
> > changed the logic to try to set the mode on all connected outputs rather
> > than abort upon the first failure. The return error code was then
> > tweaked such that it reported success if it set a mode on any crtc.
> > However, this confuses the headless case where we never enable any crtcs
> > and also, importantly, never fail to set a crtc.
> Oops. Nice catch. So, we fail only if there are outputs and none have
> managed to be configured.
> Reviewed-by: Keith Packard <keithp at keithp.com>

Oops, missed my sob,
Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Perhaps also credit Maarten for creating exactly the same patch:
Signed-off-by: Maarten Lankhorst <maarten.lankhorst at canonical.com>

Chris Wilson, Intel Open Source Technology Centre

More information about the xorg-devel mailing list