[PATCH evdev] Fail to set up devices that only have MT axes but no ABS_X/Y equivalents (#64029)
peter.hutterer at who-t.net
Tue Apr 30 14:50:21 PDT 2013
On Tue, Apr 30, 2013 at 10:51:16AM +0200, Benjamin Tissoires wrote:
> On Mon, Apr 29, 2013 at 3:51 AM, Peter Hutterer
> <peter.hutterer at who-t.net> wrote:
> > The kernel should give us ABS_X/Y for backwards compat but some devices
> > don't. For now, ignore these devices as evdev is not suited to handle this
> > yet and will crash if a device is set up without axes (i.e.
> > pEvdev->vals == NULL) and later receives an event from an MT axis.
> > X.Org Bug 64029 <http://bugs.freedesktop.org/show_bug.cgi?id=64029>
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires at gmail.com>
> Thanks for the "fix" Peter :)
thanks for the review. I should point out that the commit message is
imprecise, it should read
"Fail to set up _axes for_ devices that only have..."
if the devices has keys/buttons, they will continue to work.
More information about the xorg-devel