[PATCH][xf86-video-mga] build: dont use AC_CHECK_FILE when enabling DRI

Alan Coopersmith alan.coopersmith at oracle.com
Fri Aug 2 20:27:36 PDT 2013


On 07/31/13 09:37 AM, Ross Burton wrote:
> Automatically enabling or disabling a feature based on installed files isn't
> deterministic, and AC_CHECK_FILE returns an error when cross-compiling.
>
> Fix this by enabling DRI by default, and removing the explicit file checks as
> pkg-config is good enough.
>
> (#57606)
>
> Signed-off-by: Ross Burton <ross.burton at intel.com>
> ---
>   configure.ac |   26 +++-----------------------
>   1 file changed, 3 insertions(+), 23 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index fca1a9c..f073ad9 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -55,9 +55,10 @@ AC_ARG_WITH(xorg-module-dir,
>               [moduledir="$libdir/xorg/modules"])
>
>   AC_ARG_ENABLE(dri, AS_HELP_STRING([--disable-dri],
> -                                  [Disable DRI support [[default=auto]]]),
> +                                  [Disable DRI support [[default=enabled]]]),

I might leave that as default=auto, but otherwise looks good to me.

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list