[PATCH:libX11 02/12] xlibi18n: convert sprintf calls to snprintf

Alan Coopersmith alan.coopersmith at oracle.com
Sun Aug 11 16:27:36 PDT 2013


On 08/11/13 02:46 AM, Matthieu Herrb wrote:
> On Sat, Aug 10, 2013 at 01:54:59PM -0700, Alan Coopersmith wrote:
>> Previous code seemed to assume that printf("%s", NULL) would result
>> in a 0-length string, not "(null)" or similar, but since there's no
>> point looking for files in "(null)/filepath...", instead we just
>> skip over NULL entries in search paths when generating file names.
>>
>> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>
> The first part doen't match the description above, but makes sense
> too. Perhaps commit it separatly ?

Yeah, that bit of the description really only applies to the lcFile.c changes.
I can split that out.

> Also, given how args[] is built in parse_line() I fail to see how one
> element could be NULL.

I didn't go back to check that, just saw the existing code was checking for
those being NULL.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list