[PATCH:libX11 03/12] udcInf.c: convert sprintf calls to snprintf

Alan Coopersmith alan.coopersmith at oracle.com
Sun Aug 11 17:05:32 PDT 2013


On 08/11/13 02:52 AM, Matthieu Herrb wrote:
> I have the impression that from could be changed to 'char *' in
> _xudc_code_to_glyph(), eliminating a few casts.

Perhaps, though I can't actually tell what that code is for at the
moment.  The only reference to _xudc_code_to_glyph() that git grep
finds is the function itself - no callers, no storing in a function
pointer, nothing.   And of course, we never actually build that file:

configure.ac:
AM_CONDITIONAL(UDC, test xfalse = xtrue)

src/Makefile.am:

if UDC
libX11_la_SOURCES+=udcInf.c
endif

Looking in an old copy of the X11R6.8.2 monolith I have handy,
it wasn't included in the Imakefile at all, just sitting in the
source directory unused.   (And half the comments in the source
file appearing to be in Japanese doesn't help me understand.)

Perhaps the entire file is dead code to be removed?   I guess I'll
drop this patch and do a removal patch instead.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list