[PATCH imake] Replace fprintf with fputs

Ángel González ingenit at zoho.com
Sat Aug 17 08:55:15 PDT 2013


On 17/08/13 14:17, Julien Cristau wrote:
> Fixes build failure with -Werror=format-security:
> imake.c:1008:5: error: format not a string literal and no format arguments [-Werror=format-security]
>       fprintf (inFile, command);
>       ^
>
> Signed-off-by: Julien Cristau<jcristau at debian.org>

Interesting. This would usually be a typical security issue.
(‘security’ as it would allow a malformed file to crash imake or maybe 
even code execution). But the fact that the file is the output of a file 
where the only variation is in integer numbers and whose source code is 
hardcoded into imake... it is just peculiar.

I support the change, of course.




More information about the xorg-devel mailing list