[PATCH] Use the right variable names for the compiler flags in XORG_TESTSET_CFLAGS

Sedat Dilek sedat.dilek at gmail.com
Mon Aug 26 02:33:07 PDT 2013


On Sun, Aug 25, 2013 at 7:51 PM, Alan Coopersmith
<alan.coopersmith at oracle.com> wrote:
> On 08/25/13 07:04 AM, Sedat Dilek wrote:
>>
>> [ CC Alan C. ]
>>
>> Looking at [1], this patch was not pushed.
>> Any reason speaking against it?
>
>
> I thought someone else had reviewed it and Chris was going to push it,
> since he has direct push access to the X.Org repos.   I don't usually
> track patches from other X.Org developers who can push things themselves.
>

[ Anyone know the new email-address of Chase Douglas? ]

I don't know anything about your "maintainer" or "developer" policies.
The Linux-kernel sources have a MAINTAINERS file and a script to list
all involved maintainers in a certain area.
>From the xserver I know that there exist diverse persons as release
manager or maintainer of stable GIT branches.
Where can someone find such informations about your pushing and
maintainer policies?

>
>> Are you planning a new util/macros release soon?
>
>
> I'm not, since so far there's just cosmetic changes since the last release.
>
> Despite how it may seem sometimes, I am just one of a couple dozen people
> who
> can make releases, so any one of those can decide it's time for a release.
> For
> most of our components, releases aren't really planned out in advance,
> mostly
> just "I'm updating my distro's package and am too lazy to generate & test
> patches, so I'll make a new upstream release" or "Hmm, this git log looks
> like there's enough change since the last release to make it worth spending
> 5 minutes to roll out new tarballs."
>

This patch by Chris was no "cosmetic" one.
I build my Linux graphics stack with LLVM/Clang and fell over it when
compiling intel-ddx.
Chris was so kind to analyse and provide a patch for the issue.
"Fix spacing in XORG_TESTSET_CFLAG" [1] can be seen as a cosmetic change.

- Sedat -

[1] http://cgit.freedesktop.org/xorg/util/macros/commit/?id=0890e4003aacfa7113ab3f4e3ad7c5636f8e922a


More information about the xorg-devel mailing list